MNT/TST: Update SWAPI packet definition and tests #803
Conversation
This removes some unnecessary utils functions and moves over to packet_file_to_datasets()
greglucas
added
Ins: SWAPI
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def decom_test_science_data(swapi_l0_test_data_path): |
There was a problem hiding this comment.
It is interesting that they gave you "derived_values" for the science data, but didn't use any "derived_values" for the housekeeping. That is why we have these two different fixtures here now.
There was a problem hiding this comment.
yes. That's why I had to add if and else in test but your approach is much better.
|
The failing tests are due to an issue upstream with space_packet_parser that has already been fixed, but not released yet. medley56/space_packet_parser#54 I'm not sure there is much we can do about this until the fix is out. |
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def decom_test_science_data(swapi_l0_test_data_path): |
There was a problem hiding this comment.
yes. That's why I had to add if and else in test but your approach is much better.
|
Converting to draft since this requires changes to Space Packet Parser that will be released in the next version. Need to revisit this then when we upgrade that dependency version. |
This removes some unnecessary utils functions and moves over to
packet_file_to_datasets()Note that updating the packet definition also changed the
plan_id_scienceback toplan_idwhich was in the original spreadsheet definition. This is because they can now have different bit lengths between the packets.The packet definition also does not have the
AUTpacket defined in it anymore, do we want to add that one to the definition, or leave it out? I left it out for now and just removed that test.